On Fri, 30 Aug 2019 11:35:46 +0000, Sverdlin, Alexander (Nokia - DE/Ulm) wrote: > Hello Jean, > > On 28/08/2019 15:58, Jean Delvare wrote: > > Also it is mandatory to restore the value of SMBSLVCMD before returning > > the control back to the BIOS. Currently this is only being done when > > the FEATURE_HOST_NOTIFY bit is set because that's the only case where > > we change the value of that register, but if we change it > > unconditionally then it must be saved and restored unconditionally too. > > could you please tell a bit more about the use case, where/how exactly one > can "return control back to the BIOS"? Maybe referencing the functions in > the driver... i801_remove() and i801_shutdown(). Basically when you reboot the system. Possibly also on suspend-to-disk in certain cases, I'm not sure. In general shutdown + cold boot is OK either way because on cold boot the chipsets gets hard-reset anyway. -- Jean Delvare SUSE L3 Support
