On Sat, Jun 15, 2019 at 05:11:24PM +0200, Jean Delvare wrote: > On Fri, 14 Jun 2019 17:47:43 +0300, Andy Shevchenko wrote: > > On Fri, Jun 14, 2019 at 04:30:41PM +0200, Jean Delvare wrote: > > > In my books, you should never rely on a header including for you > > > another header you need. Is there a reason for not following that > > > principle here? > > > > init.h vs. module.h is a special case. Otherwise I agree with you. > > Why? Where is this documented? Paul did this split in the commit 0fd972a7d91d6e15393c449492a04d94c0b89351 Author: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Date: Fri May 1 20:13:42 2015 -0400 module: relocate module_init from init.h to module.h I have no idea where it should be documented if it's not. Let Paul speak. -- With Best Regards, Andy Shevchenko