Hi Andy, On Thu, 13 Jun 2019 19:45:29 +0300, Andy Shevchenko wrote: > There is no need to include linux/init.h when at the same time > we include linux/module.h. > > Remove redundant inclusion. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-i801.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 03100f5fc0e9..5613c1ef1af4 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -85,7 +85,6 @@ > #include <linux/stddef.h> > #include <linux/delay.h> > #include <linux/ioport.h> > -#include <linux/init.h> > #include <linux/i2c.h> > #include <linux/i2c-smbus.h> > #include <linux/acpi.h> In my books, you should never rely on a header including for you another header you need. Is there a reason for not following that principle here? -- Jean Delvare SUSE L3 Support
