On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> > > +properties:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> >
> > These 2 are covered by i2c-controller.yaml, right?
>
> Indeed, I've removed them.
>
> > > +examples:
> > > + - |
> > > + p2wi@1f03400 {
> >
> > i2c@...
> >
> > That should fail on the schema (I need to get the schema checking of
> > examples finished.)
>
> That would be great :) The compilation of the examples alone already
> caught a good number of examples that weren't even compiling.
I'm primarily waiting on a dtc change to be accepted[1]. Feel free to
review/ack.
> Speaking of examples, one thing that would be great too would be to
> allow the usage of our C headers. It's not supported at the moment,
> and this often ends up with an example that is less readable than the
> actual DT.
It should be. You just have to add them. See
Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for
example.
Maybe the common interrupt and gpio ones should be added by default.
Rob
[1] https://www.spinics.net/lists/devicetree-compiler/msg02709.html
