Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> > +properties:
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
>
> These 2 are covered by i2c-controller.yaml, right?

Indeed, I've removed them.

> > +examples:
> > +  - |
> > +    p2wi@1f03400 {
>
> i2c@...
>
> That should fail on the schema (I need to get the schema checking of
> examples finished.)

That would be great :) The compilation of the examples alone already
caught a good number of examples that weren't even compiling.

Speaking of examples, one thing that would be great too would be to
allow the usage of our C headers. It's not supported at the moment,
and this often ends up with an example that is less readable than the
actual DT.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux