Hi Wolfram,
> -----Original Message-----
> From: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Sent: Friday, June 7, 2019 1:33 AM
> To: Ajay Gupta <ajaykuee@xxxxxxxxx>
> Cc: heikki.krogerus@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; Ajay Gupta <ajayg@xxxxxxxxxx>
> Subject: Re: [PATCH v4 1/5] i2c: nvidia-gpu: refactor master_xfer
>
> > Changes from v3->v4:
> > - Further refactor master_xfer based on Wolfram's comment.
>
> Yay, looks even better. One thing to improve, though.
>
> > status = gpu_i2c_stop(i2cd);
>
> send_stop = false;
>
> > - if (status < 0)
> > - return status;
> > + if (status < 0) {
> > + send_stop = false;
>
> and skip it here...
>
> > + goto exit;
> > + }
> >
> > - return i;
> > -stop:
> > - status2 = gpu_i2c_stop(i2cd);
> > - if (status2 < 0)
> > - dev_err(i2cd->dev, "i2c stop failed %d\n", status2);
> > + send_stop = false;
>
> ... and here.
Sure, will fix.
Thanks
>nvpublic
