Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/6/19 4:57 AM, Wolfram Sang wrote:
On Thu, Jun 06, 2019 at 12:35:23AM -0700, Bitan Biswas wrote:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c

Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.

Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx>

I wonder why you didn't fix this checkpatch defect?

WARNING: A patch subject line should describe the change not the tool that found it

I ran checkpatch.pl on the source file only hence missed this warning. I shall fix this in updated patch.

-Thanks,
 Bitan




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux