On 04. 06. 19 17:41, Robert Hancock wrote: > On 2019-06-04 12:22 a.m., Michal Simek wrote: >> +Shubhrajyoti, >> >> On 04. 06. 19 1:33, Robert Hancock wrote: >>> This driver does not support reading more than 255 bytes at once because >>> the register for storing the number of bytes to read is only 8 bits. Add >>> a max_read_len quirk to enforce this. >> >> How did you find it out? >> Any particular issue you have had that you were looking for a solution? >> >> I think there is more things behind which should be described in commit >> message. > > We ran into this issue with the SFP driver which attempted to read 256 > bytes at once from the I2C device. It seems like this caused the driver > and/or logic to get into an invalid state because it treated the number > of bytes to read as 0. Rejecting the unsupported transfer at least makes > it easier to debug what is going on. > > I can respin with that in the commit message if it seems relevant. Yes please will be good to have this in commit message. Thanks, Michal
