On Tue, Jun 04, 2019 at 08:00:52PM +0300, Andy Shevchenko wrote: > On Tue, May 28, 2019 at 03:28:56PM +0100, Charles Keepax wrote: > > Use the available IRQ helper functions, most of the functions have > > additional helpful side affects like configuring the trigger type of the > > IRQ. > > > > You do here two things, i.e. > - splitting out helper function > - converting it to use helpers > > I would split the patch to do exact these steps separately, e.g.: > - splitting out to a local helper > - replacing open coded stuff with existing helpers > This can't really be done like this, the helper is called by acpi_dev_get_resources and I need the acpi_resource from that to call acpi_dev_resource_interrupt. I guess I could do a separate patch to start using i2c_dev_irq_from_resource if that would be preferrable? But I think the rest needs to stay together. Thanks, Charles
