On Thu, 30 May 2019 at 23:50, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > The S3C2410 does some funny dance around its pins: > - First try to call back to the platform to get and control > some GPIO pins > - If this doesn't work, it tries to get a pin control handle > - If this doesn't work, it retrieves two GPIOs from the device > tree node and does nothing with them > > If we're gonna retrieve two GPIOs and do nothing with them, we > might as well do it using the GPIO descriptor API. When we use > the resource management API, the code gets smaller. > > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > drivers/i2c/busses/i2c-s3c2410.c | 47 ++++++-------------------------- > 1 file changed, 9 insertions(+), 38 deletions(-) Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof