On Mon, May 27, 2019 at 04:19:29PM +0100, Charles Keepax wrote:
> static int i2c_acpi_get_info(struct acpi_device *adev,
> struct i2c_board_info *info,
> struct i2c_adapter *adapter,
> acpi_handle *adapter_handle)
> {
> - struct list_head resource_list;
> struct i2c_acpi_lookup lookup;
> - int irq = -ENOENT;
> int ret;
>
> memset(&lookup, 0, sizeof(lookup));
> @@ -186,16 +202,9 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
> *adapter_handle = lookup.adapter_handle;
>
> /* Then fill IRQ number if any */
> - INIT_LIST_HEAD(&resource_list);
> - ret = acpi_dev_get_resources(adev, &resource_list,
> - i2c_acpi_add_resource, &irq);
> - if (ret < 0)
> - return -EINVAL;
> -
> - if (irq >= 0)
> - info->irq = irq;
> -
> - acpi_dev_free_resource_list(&resource_list);
> + ret = i2c_acpi_get_irq(adev);
> + if (ret >= 0)
Same comment here regarding irq == 0.
