Re: [PATCH v1 i2c] i2c: mlxcpld: Fix wrong initialization order in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 16, 2019 at 05:15:41PM +0000, Vadim Pasternak wrote:
> Fix wrong order in probing routine initialization - field `base_addr'
> is used before it's initialized. Move assignment of 'priv->base_addr`
> to the beginning, prior the call to mlxcpld_i2c_read_comm().
> Wrong order caused the first read of capability register to be executed
> at wrong offset 0x0 instead of 0x2000. By chance it was a "good
> garbage" at 0x0 offset.
> 
> Fixes: 313ce648b5a4 ("i2c: mlxcpld: Add support for extended transaction length for i2c-mlxcpld")
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx>

Applied to for-current and added a stable tag, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux