On 2019/5/10 20:18, Jean Delvare wrote: > On Fri, 10 May 2019 17:35:46 +0800, Kefeng Wang wrote: >> On 2019/5/10 16:09, Jean Delvare wrote: >>> We don't need this anyway. The comment says it can't fail, so why >>> bother checking for a condition which will never happen? >> The ioremap could fails due to no memory, our inner test robot(enable FAULT_INJECTION) >> >> find this issue. > The code only runs on x86 where this specific memory segment is > standardized for the purpose. That's how we know it "can't fail". > > That being said, maybe it could fail for other reasons (internal kernel > bug, or bogus BIOS maybe), and I don't care adding the check > anyway, as this code path is not performance critical. Got it , please ignore it. >
