Hi Vadim, I have addressed your comments: 1) removed typecasting and replaced it with a macro to get the 8 bit address. I think it is more readable this way. 2) added space Thank you for your feedback! Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 ++++++++++ drivers/char/ipmi/Kconfig | 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi/ipmb_dev_int.c | 399 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 511 insertions(+) create mode 100644 Documentation/IPMB.txt create mode 100644 drivers/char/ipmi/ipmb_dev_int.c -- 2.1.2
