Don't mind either way, please do as you see fit On Mon, May 6, 2019 at 3:04 PM Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> wrote: > > On 5/6/19 4:16 PM, Jean Delvare wrote: > > Some EE1004 implementations will not properly ack page selection > > commands. They still set the page correctly, so there is no actual > > error. Deal with this case gracefully by checking the currently > > selected page after we receive a nack. If the page is set right then > > we can continue. > > > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > > Tested-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > > drivers/misc/eeprom/ee1004.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > Does Dreamcat4 deserve reported and tested by tags here? I guess > anonymous address is fine with those tags? > > (I re-tested these two patches on top of v5.1 and they make decode-dimms > working on a machine with 2-4 * Crucial DD4 dimms) > > -- > Jarkko