Hi Vadim, I apologize I forgot to address your previous comment concerning the ACPI table. I have added the ACPI device id as well as documented it for whomever wants to use either the ACPI table or device tree. I did not need that for my testing due to our internal build tools/ code structure. But I have tested with the device tree and ACPI table as well and it works fine. I have addressed your comment concerning using macros instead of magic numbers. Also, since both you and Corey suggest to not use typecasting, I will probably change it to GENMASK in my next update. I am waiting for one more advocate against typecasting! Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 ++++++++++ drivers/char/ipmi/Kconfig | 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi/ipmb_dev_int.c | 397 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 509 insertions(+) create mode 100644 Documentation/IPMB.txt create mode 100644 drivers/char/ipmi/ipmb_dev_int.c -- 2.1.2
