Re: [PATCH v3 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > > +What:		/sys/bus/i2c/.../idle_state
> > > > +Date:		January 2019
> > > > +KernelVersion:	5.2
> > > > +Contact:	Robert Shearman <robert.shearman@xxxxxxx>
> > > > +Description:
> > > > +		Value that can be written to control the behaviour of
> > > > +		the multiplexer on idle. Possible values:
> > > > +		-2 - disconnect on idle, i.e. deselect the last used
> > > > +		     channel, which is useful when there is a device
> > > > +		     with an address that conflicts with another
> > > > +		     device on another pca954x mux on the same parent
> > > 
> > > Nit: It doesn't need to be a PCA954x mux, it could be any mux.
> > 
> > And maybe say that it only exists for mux devices?
> > 
> 
> Maybe I'm misunderstanding you, but does the filename of
> sysfs-bus-i2c-devices-pca954x not already convey that information?

Unless I am overlooking something, the "What:" line above has no
indication that the idle_state file only exists for muxes. So, it could
be assumed it exists for every I2C device. My suggestion was to make
that super clear in the "Description" that this is not the case.

Does that make sense?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux