Re: [PATCH v3 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/02/2019 13:16, Wolfram Sang wrote:

  .../ABI/testing/sysfs-bus-i2c-devices-pca954x | 20 +++++

Should not ABI/... patches go to someone? Who? Did you use
get_maintainer.pl? I think you should at least include the main kernel
list? Maybe someone filters messages looking for ABI changes?

CCing Greg is a good idea here. The hunk doesn't really to go via his
tree AFAIK but an ack from him might be good.

Ok, will do.


+What:		/sys/bus/i2c/.../idle_state
+Date:		January 2019
+KernelVersion:	5.2
+Contact:	Robert Shearman <robert.shearman@xxxxxxx>
+Description:
+		Value that can be written to control the behaviour of
+		the multiplexer on idle. Possible values:
+		-2 - disconnect on idle, i.e. deselect the last used
+		     channel, which is useful when there is a device
+		     with an address that conflicts with another
+		     device on another pca954x mux on the same parent

Nit: It doesn't need to be a PCA954x mux, it could be any mux.

And maybe say that it only exists for mux devices?


Maybe I'm misunderstanding you, but does the filename of sysfs-bus-i2c-devices-pca954x not already convey that information?

Thanks,
Rob



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux