On Mon, Jan 07, 2019 at 09:47:38AM +0100, Oleksij Rempel wrote: > Make sure, i2c_imx_probe() well get and forward same error values as > i2c_imx_dma_request(). Maybe better: Improve the error handling in i2c_imx_dma_request() and let it return an error indication that the caller then can handle accordingly. > -static void i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > dma_addr_t phy_addr) This is a good opportunity to realign the continuation line to the opening parenthesis. Otherwise the patch looks good. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
