Hello, On Mon, Jan 07, 2019 at 09:47:37AM +0100, Oleksij Rempel wrote: > Current implementation will print "can't use DMA, using PIO instead", > which is confusing and mostly interpreted as error. At least on i.MX5x, > DMA event for I2C is muxed with SDHC. So it is project specific > configuration. On other hand, real error have debug level. > > With this patch real error should be printed and configuration specific > state will become silent. I'd write: At least on i.MX5x, the DMA events for I2C and SDHC use the same channel and there can only be a single user. So in this case there should be no message emitted that looks like an error if the I2C device doesn't have an assigned DMA channel. In contrast real problems that were only emitted at debug level before should be described at a higher level to be better visible and so understandable. > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> The patch is fine and can have my Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
