Re: [PATCH v2] eeprom: at24: Add 24c2048

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



pon., 22 paź 2018 o 16:59 Adrian Bunk <bunk@xxxxxxxxxx> napisał(a):
>
> On Mon, Oct 22, 2018 at 12:36:45PM +0200, Bartosz Golaszewski wrote:
> > sob., 20 paź 2018 o 20:25 Adrian Bunk <bunk@xxxxxxxxxx> napisał(a):
> > >
> > > Works with an ST M24M02.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> > > ---
> > >  drivers/misc/eeprom/at24.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> > > index 7e50e1d6f58c..94836fcbe721 100644
> > > --- a/drivers/misc/eeprom/at24.c
> > > +++ b/drivers/misc/eeprom/at24.c
> > > @@ -173,6 +173,7 @@ AT24_CHIP_DATA(at24_data_24c128, 131072 / 8, AT24_FLAG_ADDR16);
> > >  AT24_CHIP_DATA(at24_data_24c256, 262144 / 8, AT24_FLAG_ADDR16);
> > >  AT24_CHIP_DATA(at24_data_24c512, 524288 / 8, AT24_FLAG_ADDR16);
> > >  AT24_CHIP_DATA(at24_data_24c1024, 1048576 / 8, AT24_FLAG_ADDR16);
> > > +AT24_CHIP_DATA(at24_data_24c2048, 2097152 / 8, AT24_FLAG_ADDR16);
> > >  /* identical to 24c08 ? */
> > >  AT24_CHIP_DATA(at24_data_INT3499, 8192 / 8, 0);
> > >
> > > @@ -199,6 +200,7 @@ static const struct i2c_device_id at24_ids[] = {
> > >         { "24c256",     (kernel_ulong_t)&at24_data_24c256 },
> > >         { "24c512",     (kernel_ulong_t)&at24_data_24c512 },
> > >         { "24c1024",    (kernel_ulong_t)&at24_data_24c1024 },
> > > +       { "24c2048",    (kernel_ulong_t)&at24_data_24c2048 },
> > >         { "at24",       0 },
> > >         { /* END OF LIST */ }
> > >  };
> > > @@ -227,6 +229,7 @@ static const struct of_device_id at24_of_match[] = {
> > >         { .compatible = "atmel,24c256",         .data = &at24_data_24c256 },
> > >         { .compatible = "atmel,24c512",         .data = &at24_data_24c512 },
> > >         { .compatible = "atmel,24c1024",        .data = &at24_data_24c1024 },
> > > +       { .compatible = "atmel,24c2048",        .data = &at24_data_24c2048 },
> > >         { /* END OF LIST */ },
> > >  };
> > >  MODULE_DEVICE_TABLE(of, at24_of_match);
> > > --
> > > 2.11.0
> > >
> >
> > Thanks, I'll pick it up after the merge window.
>
> Thanks.
>
> I just realized that I forgot to add the entry to
> Documentation/devicetree/bindings/eeprom/at24.txt,
> fixed patch is below.
>

Hi,

please send it to the DT maintainers as well and get their Acked-by on that.

Bart

> > Bart
>
> cu
> Adrian
>
> From 37e5b736e21bf8b27f11271893151f1a8a6821a5 Mon Sep 17 00:00:00 2001
> From: Adrian Bunk <bunk@xxxxxxxxxx>
> Date: Sat, 20 Oct 2018 20:40:16 +0300
> Subject: [PATCH] eeprom: at24: Add 24c2048
>
> Works with an ST M24M02.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
>  drivers/misc/eeprom/at24.c                        | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index aededdbc262b..f9a7c984274c 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -27,6 +27,7 @@ Required properties:
>                  "atmel,24c256",
>                  "atmel,24c512",
>                  "atmel,24c1024",
> +                "atmel,24c2048",
>
>                  If <manufacturer> is not "atmel", then a fallback must be used
>                  with the same <model> and "atmel" as manufacturer.
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 7e50e1d6f58c..94836fcbe721 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -173,6 +173,7 @@ AT24_CHIP_DATA(at24_data_24c128, 131072 / 8, AT24_FLAG_ADDR16);
>  AT24_CHIP_DATA(at24_data_24c256, 262144 / 8, AT24_FLAG_ADDR16);
>  AT24_CHIP_DATA(at24_data_24c512, 524288 / 8, AT24_FLAG_ADDR16);
>  AT24_CHIP_DATA(at24_data_24c1024, 1048576 / 8, AT24_FLAG_ADDR16);
> +AT24_CHIP_DATA(at24_data_24c2048, 2097152 / 8, AT24_FLAG_ADDR16);
>  /* identical to 24c08 ? */
>  AT24_CHIP_DATA(at24_data_INT3499, 8192 / 8, 0);
>
> @@ -199,6 +200,7 @@ static const struct i2c_device_id at24_ids[] = {
>         { "24c256",     (kernel_ulong_t)&at24_data_24c256 },
>         { "24c512",     (kernel_ulong_t)&at24_data_24c512 },
>         { "24c1024",    (kernel_ulong_t)&at24_data_24c1024 },
> +       { "24c2048",    (kernel_ulong_t)&at24_data_24c2048 },
>         { "at24",       0 },
>         { /* END OF LIST */ }
>  };
> @@ -227,6 +229,7 @@ static const struct of_device_id at24_of_match[] = {
>         { .compatible = "atmel,24c256",         .data = &at24_data_24c256 },
>         { .compatible = "atmel,24c512",         .data = &at24_data_24c512 },
>         { .compatible = "atmel,24c1024",        .data = &at24_data_24c1024 },
> +       { .compatible = "atmel,24c2048",        .data = &at24_data_24c2048 },
>         { /* END OF LIST */ },
>  };
>  MODULE_DEVICE_TABLE(of, at24_of_match);
> --
> 2.11.0
>




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux