On Thursday, September 20, 2018 3:08:28 PM CEST Jarkko Nikula wrote: > On 09/19/2018 10:15 PM, Hans de Goede wrote: > > On some Cherry Trail systems the GPU ACPI fwnode has power-resources which > > point to the PMIC, which is connected over a LPSS I2C controller. The GPU > > is a PCI device and PCI devices are powered-on at the resume_noirq resume > > phase. > > > > Since the GPU power-resources need the I2C controller, recent acpi_lpss.c > > changes now also power-up the LPSS I2C controllers on BYT and CHT devices > > in the resume_noirq resume phase. But during this phase the IRQ of the > > controller is disabled leading to these errors: > > > > i2c_designware 808622C1:06: controller timed out > > ACPI Error: AE_ERROR, Returned by Handler for [UserDefinedRegion] > > ACPI Error: Method parse/execution failed \_SB.P18W._ON, AE_ERROR > > video LNXVIDEO:00: Failed to change power state to D0 > > > > This commit makes the i2c-designware controller set the IRQF_NO_SUSPEND > > flag when requesting the interrupt on BYT and CHT devices, so that the IRQ > > is left enabled during the noirq phase, fixing this. > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > --- > > drivers/i2c/busses/i2c-designware-core.h | 1 + > > drivers/i2c/busses/i2c-designware-master.c | 2 +- > > drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- > > 3 files changed, 4 insertions(+), 3 deletions(-) > > > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > Thanks! Wolfram, any objections here?
