On 2018-09-11 18:53, Ajay Gupta wrote:
> Hi Peter,
>
>> -----Original Message-----
>> From: linux-i2c-owner@xxxxxxxxxxxxxxx <linux-i2c-owner@xxxxxxxxxxxxxxx>
>> On Behalf Of Peter Rosin
>> Sent: Tuesday, September 11, 2018 1:55 AM
>> To: Ajay Gupta <ajayg@xxxxxxxxxx>; wsa@xxxxxxxxxxxxx;
>> heikki.krogerus@xxxxxxxxxxxxxxx
>> Cc: linux-usb@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH v11 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU
>>
>> [I seem to have lost my local copy of the mail I'm responding to, so I copied
>> bits of it from an archive and broke threading in the process, sorry about that]
> That’s why was wondering how you got "goto stop" in "if (msgs[i].flags & I2C_M_RD) {"
> Block at [1]. There is actually no stop when gpu_i2c_read() fails in master_xfer()
>
> [1] https://marc.info/?l=linux-usb&m=153662481422174&w=2
No, the only message I lost was the one I quoted from. The "goto stop"
line was me saying that "goto stop" would fix a bug caused by the
unconditional "return status". I then continued saying that "goto stop"
was not perfect etc.
Cheers,
Peter
