2018-08-23 12:33 GMT+02:00 Linus Walleij <linus.walleij@xxxxxxxxxx>: > This makes it possible to pass an initialized GPIO descriptor > to the driver through platform data. > > This is useful when we are dealing with EEPROMs on expansion > boards where the GPIO has to be looked up indirectly using a > connector abstraction (several systems using the same > connector) so the machine descriptor tables cannot be used > to associate the descriptor with the device and we then want > to pass this descriptor on to the EEPROM driver this way > instead. > Ugh I don't like this at all. In fact I'm right now trying to *get rid* of platform_data from at24 in favor of device properties[1]. Part of the changes from my series actually removes the setup function from at24 and replaces it with a notifier fired by the nvmem framework. I would really prefer that we introduce some generic way of handling write-protect mechanisms in nvmem. Maybe starting by moving the wp_gpio to nvmem and then passing it in nvmem_config? Best regards, Bartosz Golaszewski [1] https://patchwork.kernel.org/cover/10562365/