2018-08-10 16:39 GMT+02:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > On Fri, Aug 10, 2018 at 11:05 AM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: >> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> >> >> We don't need to use pci_device_to_OF_node() - we can retrieve >> dev->of_node directly even for pci devices. >> > >> struct device_node *dp; >> >> - if (dev_is_pci(dev)) >> - dp = pci_device_to_OF_node(to_pci_dev(dev)); >> - else >> - dp = dev->of_node; >> - >> + dp = dev->of_node; >> addr = NULL; >> if (dp) >> addr = of_get_mac_address(dp); > > Looking more at this I could even propose to change all above by > > addr = device_get_mac_address(dev, mac_addr, ETH_ALEN); > > Thoughts? > > -- > With Best Regards, > Andy Shevchenko Indeed seems like it's even more generalized. Thanks for spotting that. Bart
