On 06/27/2018 10:59 PM, Jean Delvare wrote:
On Tue, 26 Jun 2018 17:39:13 +0300, Jarkko Nikula wrote:
Remove #ifdef CONFIG_PM_SLEEP and mark system PM suspend/resume callback
functions with __maybe_unused to make code a little bit easier to read
and to be sync with previous commit.
I have expressed my dislike of __maybe_unused twice before [1], and
I'll do it a third time. #ifdefs are better. What should be fixed is
your first patch in this series.
https://patchwork.kernel.org/patch/10397649/
I don't know what is the current trend between __maybe_unused or #ifdefs
at the moment in general, I saw recent patches doing both, probably due
personal tastes and existing style in different subsystems while making
my choice in patch 1/2.
I went to __maybe_unused after seeing
Documentation/process/coding-style.rst is marketing it but of course
that is not written in stone rule and probably just shows 2014 fashion
(21228a186869 ("CodingStyle: Add a chapter on conditional compilation")).
Anyway, hopefully we'll find better way to handle patch 1/2 issue in
PCI/PM core so we wouldn't need to touch i2c-i801 here at all.
--
Jarkko
