Re: [PATCH 2/2] i2c: i801: Mark system PM callbacks as __maybe_unused

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Jun 2018 17:39:13 +0300, Jarkko Nikula wrote:
> Remove #ifdef CONFIG_PM_SLEEP and mark system PM suspend/resume callback
> functions with __maybe_unused to make code a little bit easier to read
> and to be sync with previous commit.

I have expressed my dislike of __maybe_unused twice before [1], and
I'll do it a third time. #ifdefs are better. What should be fixed is
your first patch in this series.

https://patchwork.kernel.org/patch/10397649/

-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux