On 06/11/2018 06:20 PM, Andy Shevchenko wrote:
On Mon, 2018-06-11 at 17:22 +0300, Jarkko Nikula wrote:
This is rather readability update than micro-optimization, or if not
optimization at all. We take the input clock rate to a variable and
pass
that to SCL timing parameter calculation functions.
While at it, indent i2c_dw_scl_hcnt()/i2c_dw_scl_lcnt() argument list
to
the same alignment. Now first argument is off by one character.
I think it still doesn't explain why instead of moving other lines, you
split the first one in each excerpt like this.
Indentation goes too far right, each following line needs 7 spaces and
line length becomes over 80. I wouldn't like to go to that path.
--
Jarkko
