On Mon, 2018-06-11 at 17:22 +0300, Jarkko Nikula wrote: > This is rather readability update than micro-optimization, or if not > optimization at all. We take the input clock rate to a variable and > pass > that to SCL timing parameter calculation functions. > > While at it, indent i2c_dw_scl_hcnt()/i2c_dw_scl_lcnt() argument list > to > the same alignment. Now first argument is off by one character. I think it still doesn't explain why instead of moving other lines, you split the first one in each excerpt like this. > - hcnt = i2c_dw_scl_hcnt(i2c_dw_clk_rate(dev), > + hcnt = > + i2c_dw_scl_hcnt(ic_clk, -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy
