On Wed, Apr 11, 2018 at 11:36 AM, Jean Delvare <jdelvare@xxxxxxx> wrote: > On Wed, 11 Apr 2018 11:12:41 -0400, Jason Andryuk wrote: >> On Wed, Apr 11, 2018 at 10:54 AM, Jean Delvare <jdelvare@xxxxxxx> wrote: >> > On Wed, 11 Apr 2018 09:09:25 -0400, Jason Andryuk wrote: >> >> i801_smbus 0000:00:1f.4: i801_shutdown is called >> >> i2c i2c-6: i801_disable_host_notify: SMBSLVCMD value at removal time: 01 >> >> i2c i2c-6: i801_disable_host_notify: SMBSLVCMD reset to: 00 >> > >> > I'm curious how you managed to capture these... serial console, rsyslog? >> >> I took a video on my phone and transcribed the messages. My system >> runs rsyslog, but that exits before the shutdown initscripts call >> halt. However, at that time we are back in text mode and messages are >> printed to the laptop display. That is why I didn't write down all >> the messages from earlier - they were captured by rsyslog. The full >> output of messages is something like: >> >> i801_smbus 0000:00:1f.4: Original SMBSLVCMD value: 00 >> i801_smbus 0000:00:1f.4: SMBus using PCI interrupt >> i2c i2c-6: i801_enable_host_notify: SMBSLVCMD value before initialization: 00 >> i2c i2c-6: i801_enable_host_notify: SMBSLVCMD value after initialization: 01 >> <shutdown called> >> i2c i2c-6: i801_enable_host_notify: SMBSLVCMD value before initialization: 01 >> i2c i2c-6: i801_enable_host_notify: SMBSLVCMD value after initialization: 01 >> i801_smbus 0000:00:1f.4: i801_shutdown is called >> i2c i2c-6: i801_disable_host_notify: SMBSLVCMD value at removal time: 01 >> i2c i2c-6: i801_disable_host_notify: SMBSLVCMD reset to: 00 > > So you added the "SMBSLVCMD value before initialization" message at the > beginning of i801_enable_host_notify(), right? If so then the values > are correct even though the message itself is a bit confusing. But > anyway, this should be all clearer after I fix the unwanted > suspend/resume cycles. The message text comes from your original debugging patch - I just didn't update it. The original SMBSLVCMD value from i801_probe is printed as well as the register value before and after the writes in i801_enable_host_notify and i801_disable_host_notify. The messages should be something like "value before write" and "value after write". Regards, Jason
