Re: [PATCH] i2c: designware: suppress unneeded SDA hold time warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thu, 8 Mar 2018 16:10:09 +0200, Jarkko Nikula wrote:
> On 03/08/2018 03:45 PM, Jarkko Nikula wrote:
> > On 03/08/2018 03:23 PM, Alexander Monakov wrote:  
> >> The hardware may not support SDA hold time configuration, but if it is
> >> not set in the Device Tree either, there is no need to print a warning.
> >>
> >> Link: https://patchwork.kernel.org/patch/9681781/
> >> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>
> >> Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> >> Signed-off-by: Alexander Monakov <amonakov@xxxxxxxxx>
> >> ---
> >> Hello,
> >>
> >> Thomas originally raised this issue in April (see patchwork link), Jarkko
> >> gave his acked-by but recommended to use "else if", Wolfram agreed, and
> >> then it seems to have fallen through the cracks. Resubmitting with 
> >> "else if".
> >>  
> Actually would be good to give kudos to Thomas in commit log. Either by 
> having something like above text in the commit log or let him be the 
> author of the patch and you write your contribution before your 
> Signed-off-by.
> 
> E.g. here's one patch I trivially backported and sent to linux stable 
> but where original authorship remains:
> 
> https://www.spinics.net/lists/stable/msg219783.html
> 
> I let you and Thomas to agree which way you prefer :-)

I don't care about the authorship for such a small patch, and it's
good to have the problem fixed anyway, so I'm all for having Alexander's
patch merged.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux