On Mon, Jan 22, 2018 at 12:36:56PM +0100, Peter Rosin wrote: > Can be used during probe to double check that the probed device is > what is expected. > > Loosely based on code from Adrian Fiergolski <adrian.fiergolski@xxxxxxx>. > > Signed-off-by: Peter Rosin <peda@xxxxxxxxxx> In general, nice! I wanted to have such a function in the core but never had a device to test it with. So, much appreciated. Looks mostly good, except... > + ret = i2c_smbus_xfer(adap, I2C_ADDR_DEVICE_ID, client->flags, We shouldn't pass the flag of the clients (like PEC) here. I'd think it could be plain 0 but please double-check. > +/** > + * struct i2c_device_identity - i2c client device identification > + * @manufacturer_id: 0 - 4095, database maintained by NXP > + * @part_id: 0 - 511, according to manufacturer > + * @die_revision: 0 - 7, according to manufacturer > + */ All is nicely documented, very good! About the upstreaming procedure: Could you just make a seperate pull-request out of this feature? I'll pull that in to have it in my tree and you can still collect patches in your usual for-next branch. When the above is fixed you can add my: Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature