On Fri, Feb 16, 2018 at 01:44:55PM +0100, Linus Walleij wrote: > The variable "i2c_debug" is in a real weird place. If DEBUG > happens to be defined (because someone wants to do debugging) > the macro bit_dbg() is already using it some lines up in > the code, so compilation will fail. ? This just defines the bit_dbg macro which will not be used until i2c_debug gets defined, too. It compiles fine for me. Am I missing something? > After this patch, it is possible to define DEBUG and then > pass a debug level to the module with the i2c_debug > parameter, which is probably what is intended. We could still move it to reduce ifdeffery...
Attachment:
signature.asc
Description: PGP signature
