On Tue, Feb 20, 2018 at 01:01:21PM +0200, Andy Shevchenko wrote:
> On Sat, 2018-02-17 at 22:58 +0200, Andy Shevchenko wrote:
> > GPIO library can return -ENOSYS for the failed request.
> > Instead of failing ->probe() in this case override error code to 0.
> >
>
> Oops, Cc'ing Dominik.
> Dominik, I meant this one.
>
> > Fixes: ca382f5b38f3 ("i2c: designware: add i2c gpio recovery option")
> > Reported-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Tim Sander <tim@xxxxxxxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > drivers/i2c/busses/i2c-designware-master.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-master.c
> > b/drivers/i2c/busses/i2c-designware-master.c
> > index ae691884d071..5778908351a2 100644
> > --- a/drivers/i2c/busses/i2c-designware-master.c
> > +++ b/drivers/i2c/busses/i2c-designware-master.c
> > @@ -644,7 +644,7 @@ static int i2c_dw_init_recovery_info(struct
> > dw_i2c_dev *dev)
> > gpio = devm_gpiod_get(dev->dev, "scl", GPIOD_OUT_HIGH);
> > if (IS_ERR(gpio)) {
> > r = PTR_ERR(gpio);
> > - if (r == -ENOENT)
> > + if (r == -ENOENT || r == -ENOSYS)
> > return 0;
> > return r;
> > }
Yes, this works as well.
s/Reported-by/Reported-and-Tested-by/
Thanks,
Dominik
