On Tue, Jan 30, 2018 at 8:22 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, Jan 30, 2018 at 3:43 AM, Andrew Cooks <andrew.cooks@xxxxxxxxxxxx> wrote: >> On 29/01/18 23:30, Andy Shevchenko wrote: >>> On Mon, Jan 29, 2018 at 5:54 AM, Andrew Cooks <andrew.cooks@xxxxxxxxxxxx> wrote: >>>> + if (has_acpi_companion(&dev->dev)) { >>>> + acpi_preset_companion(&adap->dev, >>>> + ACPI_COMPANION(&dev->dev), >>>> + piix4_adapter_count++); >>>> + } >> It is similar to the topology shown in commit 8eb5c87a ("i2c: add ACPI support for I2C mux ports") > > Ah, I see now. Your initial approach seems fine. > > Perhaps even new helper can be made for users (currently i2c mux, > sdio, libata) in the future. FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko