On 2017-12-06 15:29, Bartosz Golaszewski wrote: > 2017-12-06 14:40 GMT+01:00 Peter Rosin <peda@xxxxxxxxxx>: >> Hi! >> >> Some nits... >> >> On 2017-12-06 14:01, Bartosz Golaszewski wrote: >>> There are a couple symbols defined in the driver source file which are >>> missing the at24_ prefix. This patch fixes that. >>> >>> For module params: use module_param_named() in order not to break the >>> userspace. >> >> I'd write that as "...in order to not break userspace" >> > > I would love to hear an English native speaker's opinion on that. :) "not to" or "to not" is a matter of style/taste. I mainly wanted to point out that the definite article of "userspace" should be removed, because you are not talking about one particular userspace. Cheers, peda
