Before doing bigger changes, e.g. replacing the magic config values with a struct, here comes series with smaller improvements. Heiner Kallweit (7): eeprom: at24: don't explicitely include header files which are implicitely included eeprom: at24: consider that SERIAL and MAC flags imply read-only eeprom: at24: simplify probe a little by replacing &client->dev eeprom: at24: simplify functions at24_read/write a little eeprom: at24: zero-initialize variable chip in probe eeprom: at24: don't check chip.byte_len for power of two eeprom: at24: don't check page_size for read-only chips and reorder checks drivers/misc/eeprom/at24.c | 154 +++++++++++++++++++-------------------------- 1 file changed, 64 insertions(+), 90 deletions(-) -- 2.15.0
