Re: [PATCH] power: supply: sbs-message: double left shift bug in sbsm_select()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > >  	/* chan goes from 1 ... 4 */
> > > -	reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan);
> > > +	reg = BIT(SBSM_SMB_BAT_OFFSET + chan);
> > >  	ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg);
> > >  	if (ret)
> > >  		dev_err(dev, "Failed to select channel %i\n", chan);
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>
> > 
> > sbs-manager has been added to linux-next through the i2c tree due to
> > dependencies, so this one also needs to go through i2c.
> 
> I want to send Linus my pull request early this time (like today or
> tomorrow). So, you either apply this patch then yourself afterwards on
> top of linus' tree. Or I send it to him, but then I'd need the original
> patch bounced or resent. Both fine with me.

The sbs-manager code is in linus' tree now. How would you like to
proceed?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux