Hello Juergen, On Fri, Oct 27, 2017 at 05:10:58PM +0200, Juergen Fitschen wrote: > Based on the discussion we had on the i2c-linux list [1], I wrote a patch for > AT91 hardware and tried to fulfill the Linux I2C slave interface description > [2] as good as possible. This enables aforementioned hardware to act as an I2C > slave that can be accessed by a remote I2C master. I am sorry, I missed the first discussion since I was on vacation on not in Cc. So thanks a lot for trying to mainline your work. For sure it will be useful. > > I have tested this patchset successfully on an ATSAMA5D27 with the > i2c-slave-eeprom backend for some time and I'm convinced that it works stable > enough to be reviewed by you. I never used our I2C controller in slave mode so I'll try to test it on SAMA5D2 but also with older SoCs. > > Since I am a newcomer to kernel coding, I really would like to hear your > comments on this patchset. IMO, it sounds pretty good. Regards Ludovic > > [1] https://marc.info/?t=150824004800001&r=1&w=1 > [2] https://www.kernel.org/doc/Documentation/i2c/slave-interface > > Juergen Fitschen (4): > i2c: at91: segregate master mode specific code from probe and init > func > i2c: at91: split driver into core and master file > i2c: at91: added slave mode support > i2c: at91: take slave mode capabilities of hardware into account > > MAINTAINERS | 3 +- > drivers/i2c/busses/Makefile | 4 + > drivers/i2c/busses/i2c-at91-core.c | 390 +++++++++++ > drivers/i2c/busses/i2c-at91-master.c | 804 ++++++++++++++++++++++ > drivers/i2c/busses/i2c-at91-slave.c | 147 ++++ > drivers/i2c/busses/i2c-at91.c | 1243 ---------------------------------- > drivers/i2c/busses/i2c-at91.h | 184 +++++ > 7 files changed, 1531 insertions(+), 1244 deletions(-) > create mode 100644 drivers/i2c/busses/i2c-at91-core.c > create mode 100644 drivers/i2c/busses/i2c-at91-master.c > create mode 100644 drivers/i2c/busses/i2c-at91-slave.c > delete mode 100644 drivers/i2c/busses/i2c-at91.c > create mode 100644 drivers/i2c/busses/i2c-at91.h > > -- > 2.7.4
