On 27/10/17 21:04, Wolfram Sang wrote: > On Mon, Oct 02, 2017 at 10:49:01AM +0100, Ed Blake wrote: >> The i2c-img-scb driver already dynamically enables / disables clocks to >> save power, but doesn't use the runtime PM framework. Convert the >> driver to use runtime PM, so that dynamic clock management will be >> disabled when runtime PM is disabled, and so that autosuspend can be >> used to avoid unnecessarily disabling and re-enabling clocks repeatedly >> during a sequence of transactions. >> >> Signed-off-by: Ed Blake <ed.blake@xxxxxxxxxxx> > I get on build-testing: > > drivers/i2c/busses/i2c-img-scb.c:1164:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > ? Sorry, I didn't have that warning enabled. I'll fix in v2. Ed.