On Wed, Aug 23, 2017 at 4:42 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > The commit 58a1fbbb2ee8 ("PM / PCI / ACPI: Kick devices that might have > been reset by firmware"), made PCI's and ACPI's ->complete() callbacks to > be assigned to a new API called pm_complete_with_resume_check(), which was > introduced in the same change. > > Later it turned out that using pm_complete_with_resume_check() isn't good > enough for PCI, as it needs additional PCI specific checks, before deciding > whether runtime resuming the device is needed when running the ->complete() > callback. > > This leaves ACPI being the only user of pm_complete_with_resume_check(). I would say "the ACPI PM domain" instead of just "ACPI" here, because in fact this is only about the ACPI PM domain. This more-or-less applies to all of the changelogs in this series and to some comments added by it too: please be specific that it is *only* about the ACPI PM domain. The patch itself is fine. Thanks, Rafael