Hi,
Thank you for doing this.
On 06-07-17 20:01, Andy Shevchenko wrote:
For now empty ID table is not allowed with ACPI and prevents driver to be
probed.
Add a check to allow empty ID table.
Fixes: da10c06a044b ("i2c: Make I2C ID tables non-mandatory for DT'ed devices")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
---
drivers/i2c/i2c-core-base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index c89dac7fd2e7..45231d2257ad 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -354,9 +354,10 @@ static int i2c_device_probe(struct device *dev)
/*
* An I2C ID table is not mandatory, if and only if, a suitable Device
- * Tree match table entry is supplied for the probing device.
+ * Tree or ACPI match table entry is supplied for the probing device.
*/
if (!driver->id_table &&
+ !acpi_match_device(dev->driver->acpi_match_table, &client->dev) &&
!i2c_of_match_device(dev->driver->of_match_table, client))
return -ENODEV;
