Hi Andy and Wolfram, On 一, 6月 26, 2017 at 06:28:14下午 +0800, Baolin Wang wrote: > This patch adds the I2C controller driver for Spreadtrum SC9860 platform. > > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxx> > --- > Changes since v2: > - Remove some redundant comments and parens. > - Define macros instead of magic number. > - Add some comments to explain clock formula. > - Change of_clk_get_by_name() to devm_clk_get(). > - Deal with other frequency. > - Change register definiton to low case. > - Change is_last_msg to boolean. > - Other optimization. > > Changes sice v1: > - Power on I2C device in probe(). > - Remove redundant macros and usb __maybe_unused. > - Remove redundant 'of_match_ptr'. > - Modify return values and check the return value for 'clk_prepare_enable'. > --- Do you have any more comments about this patch? Thanks.
