> > /* If irq is 0, we do polling. */ > > + if (irq < 0) > > + irq = 0; > > This does not belong to what is written in commit message. Looks like > a separate fix. True, this needs explanation. > > + of_property_read_u32_index(np, "clock-frequency", 0, > > + &i2c->algo_data.i2c_clock); > > And what prevents you to use device_property_read_*() here and get rid > of OFstuff? device_* functions are not super much known yet. Even I tend to forget them occasionally like here. We can fix it incrementally, too. But I agree, it would be nice to have it right from the beginning.
Attachment:
signature.asc
Description: PGP signature
