Re: [PATCH] i2c: i2c-imx: Use correct function to write to register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Cc += Andy Duan

On Tue, Jun 20, 2017 at 10:20:42AM +0200, Michail Georgios Etairidis wrote:
> 
> The i2c-imx driver incorrectly uses readb()/writeb() to read and 
> write to the appropriate registers when performing a repeated start. 
> The appropriate imx_i2c_read_reg()/imx_i2c_write_reg() functions 
> should be used instead. Performing a repeated start results in 
> a kernel panic. The platform is imx.

I really wonder why this didn't pop up earlier, maybe repeated start
just isn't that usual.

> Signed-off-by: Michail G Etairidis <m.etairidis@xxxxxxxxxxxx>
Fixes: ce1a78840ff7 ("i2c: imx: add DMA support for freescale i2c driver")
Fixes: 054b62d9f25c ("i2c: imx: fix the i2c bus hang issue when do repeat restart")
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux