Re: w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jan,

> It's been a year since I submitted the first version and there was no
> further feedback since my latest version from October 2016.
> 
> Have I missed something or did something wrong? Is there something I
> have to do now to have the patchset accepted?

TLDR; - I expected the Onewire maintainer Evgeniy Polyakov
<zbr@xxxxxxxxxxx> to pick it up (or to ack it so I could pick it). But
maybe he missed the patch?

Onewire is a bit special because in its directory (drivers/w1) not only
the master drivers are kept but also the slaves (like your W1-to-I2C
bridge). And because your driver goes below drivers/w1 I was expecting
that Evgeniy would pick it up. It is his realm. Maybe he wasn't on CC?

From my side, the I2C part was fine, but I obviusly cannot review the
Onewire part. This should be done by Evgeniy or some other Onewire
expert. So an Acked-by: from one of them would be good.

However, your patch 1/2 ("wire: export w1_touch_bit") really needs to go
via the Onewire tree. I could only pick it if the subsystem was
orphaned or Evgeniy really wants me to.

Question answered? Sorry for the delay...

All the best,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux