Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luis,

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.12-rc5 next-20170616]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luis-Oliveira/i2c-designware-add-I2C-SLAVE-support/20170615-014456
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-randconfig-a0-06181216 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-designware-slave.c: In function 'i2c_dw_irq_handler_slave':
>> drivers/i2c/busses/i2c-designware-slave.c:285:3: error: implicit declaration of function 'i2c_slave_event' [-Werror=implicit-function-declaration]
      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
      ^~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:285:31: error: 'I2C_SLAVE_WRITE_REQUESTED' undeclared (first use in this function)
      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c:285:31: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/i2c/busses/i2c-designware-slave.c:293:12: error: 'I2C_SLAVE_WRITE_RECEIVED' undeclared (first use in this function)
               I2C_SLAVE_WRITE_RECEIVED,
               ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:306:11: error: 'I2C_SLAVE_READ_REQUESTED' undeclared (first use in this function)
              I2C_SLAVE_READ_REQUESTED,
              ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:313:36: error: 'I2C_SLAVE_READ_PROCESSED' undeclared (first use in this function)
      if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED,
                                       ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:317:31: error: 'I2C_SLAVE_STOP' undeclared (first use in this function)
      i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
                                  ^~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c: At top level:
>> drivers/i2c/busses/i2c-designware-slave.c:353:2: error: unknown field 'reg_slave' specified in initializer
     .reg_slave = i2c_dw_reg_slave,
     ^
   drivers/i2c/busses/i2c-designware-slave.c:353:15: warning: excess elements in struct initializer
     .reg_slave = i2c_dw_reg_slave,
                  ^~~~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c:353:15: note: (near initialization for 'i2c_dw_algo')
>> drivers/i2c/busses/i2c-designware-slave.c:354:2: error: unknown field 'unreg_slave' specified in initializer
     .unreg_slave = i2c_dw_unreg_slave,
     ^
   drivers/i2c/busses/i2c-designware-slave.c:354:17: warning: excess elements in struct initializer
     .unreg_slave = i2c_dw_unreg_slave,
                    ^~~~~~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c:354:17: note: (near initialization for 'i2c_dw_algo')
   cc1: some warnings being treated as errors

vim +/i2c_slave_event +285 drivers/i2c/busses/i2c-designware-slave.c

   279		dev_dbg(dev->dev,
   280			"%#x STAUTS SLAVE_ACTTVITY=%#x : RAW_INTR_STAT=%#x"
   281			" : INTR_STAT=%#x\n",
   282			enabled, slave_activity, raw_stat, stat);
   283	
   284		if ((stat & DW_IC_INTR_RX_FULL) && (stat & DW_IC_INTR_STOP_DET))
 > 285			i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
   286	
   287		if (stat & DW_IC_INTR_RD_REQ) {
   288			if (slave_activity) {
   289				if (stat & DW_IC_INTR_RX_FULL) {
   290					val = dw_readl(dev, DW_IC_DATA_CMD);
   291	
   292					if (!i2c_slave_event(dev->slave,
 > 293							     I2C_SLAVE_WRITE_RECEIVED,
   294							     &val)) {
   295						dev_vdbg(dev->dev, "Byte %X acked!",
   296							 val);
   297					}
   298					dw_readl(dev, DW_IC_CLR_RD_REQ);
   299					stat = i2c_dw_read_clear_intrbits_slave(dev);
   300				} else {
   301					dw_readl(dev, DW_IC_CLR_RD_REQ);
   302					dw_readl(dev, DW_IC_CLR_RX_UNDER);
   303					stat = i2c_dw_read_clear_intrbits_slave(dev);
   304				}
   305				if (!i2c_slave_event(dev->slave,
 > 306						     I2C_SLAVE_READ_REQUESTED,
   307						     &val))
   308					dw_writel(dev, val, DW_IC_DATA_CMD);
   309			}
   310		}
   311	
   312		if (stat & DW_IC_INTR_RX_DONE) {
 > 313			if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED,
   314					     &val))
   315				dw_readl(dev, DW_IC_CLR_RX_DONE);
   316	
 > 317			i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
   318			stat = i2c_dw_read_clear_intrbits_slave(dev);
   319			return 1;
   320		}
   321	
   322		if (stat & DW_IC_INTR_RX_FULL) {
   323			val = dw_readl(dev, DW_IC_DATA_CMD);
   324			if (!i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_RECEIVED,
   325					     &val))
   326				dev_vdbg(dev->dev, "Byte %X acked!", val);
   327		} else {
   328			i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
   329			stat = i2c_dw_read_clear_intrbits_slave(dev);
   330		}
   331	
   332		//~ if (stat & DW_IC_INTR_TX_OVER)
   333			//~ dw_readl(dev, DW_IC_CLR_TX_OVER);
   334	
   335		return 1;
   336	}
   337	
   338	static irqreturn_t i2c_dw_isr_slave(int this_irq, void *dev_id)
   339	{
   340		struct dw_i2c_dev *dev = dev_id;
   341		int ret;
   342	
   343		i2c_dw_read_clear_intrbits_slave(dev);
   344		ret = i2c_dw_irq_handler_slave(dev);
   345		if (ret > 0)
   346			complete(&dev->cmd_complete);
   347	
   348		return IRQ_RETVAL(ret);
   349	}
   350	
   351	static struct i2c_algorithm i2c_dw_algo = {
   352		.functionality = i2c_dw_func,
 > 353		.reg_slave = i2c_dw_reg_slave,
 > 354		.unreg_slave = i2c_dw_unreg_slave,
   355	};
   356	
   357	int i2c_dw_probe_slave(struct dw_i2c_dev *dev)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux