>>>>> "Stefan" == Stefan Roese <sr@xxxxxxx> writes:
> I've noticed that this driver adds a timeout pause of 1 second after
> each xfer. This is due to the wait_event_timeout() call in ocores_xfer()
> using a "HZ" timeout value and a missing call to wake_up() in
> ocores_process() called by the interrupt handler when the state changes
> to STATE_DONE at the end of the frame.
> This patch adds the missing call resulting in the removal of this 1
> second timeout delay after each xfer.
> Signed-off-by: Stefan Roese <sr@xxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-ocores.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index 34f1889a4073..5f8395ea0106 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -191,6 +191,7 @@ static void ocores_process(struct ocores_i2c *i2c)
> } else {
> i2c-> state = STATE_DONE;
> oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_STOP);
> + wake_up(&i2c->wait);
> return;
It is close to 10 years ago since I last had access to any boards with
the ocores controller, but the logic in ocores_process() indicates that
the controller would generate another interrupt once the stop condition
has been sent:
if ((i2c->state == STATE_DONE) || (i2c->state == STATE_ERROR)) {
/* stop has been sent */
oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
wake_up(&i2c->wait);
return;
}
Do you not see this interrupt?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
