On Sun, May 21, 2017 at 10:42 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx> > --- > drivers/misc/apds990x.c | 2 +- > include/linux/{i2c => platform_data}/apds990x.h | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename include/linux/{i2c => platform_data}/apds990x.h (100%) > > diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c > index dfb72ecfa60461..c341164edaad01 100644 > --- a/drivers/misc/apds990x.c > +++ b/drivers/misc/apds990x.c > @@ -32,7 +32,7 @@ > #include <linux/delay.h> > #include <linux/wait.h> > #include <linux/slab.h> > -#include <linux/i2c/apds990x.h> > +#include <linux/platform_data/apds990x.h> The new location is clearly better than the old, but I notice that in both patches, there is not a single definition for the platform_data structure in the kernel and both drivers refuse to load when they do not get passed valid platform_data. Should we also remove the drivers or move them into staging? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html