Hi Jean, > > -module_init(i2c_stub_init); > > -module_exit(i2c_stub_exit); > > I'm not sure on what you base your claim that this is the "proper > place". checkpatch doesn't complain about either, and if anything, the > original style (module_init/exit) at end of file seems a lot more > popular through the kernel tree. In my book, this is more "old-style" than "popular" ;) And while I am quite sure my change is common these days (put annotations directly behind the functions), I in deed cannot find any public reference for that. No strong feelings, I can drop it. Thanks, Wolfram
Attachment:
signature.asc
Description: PGP signature